-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for SR-15123 #685
Conversation
We might not need this pending swiftlang/llvm-project#3246 but it does appear to work (only with the change being reverted though, otherwise it fails) |
optimized a bit for revertability here |
01b2539
to
4f268f1
Compare
4f268f1
to
bf3e30e
Compare
bf3e30e
to
584276a
Compare
584276a
to
4951b9d
Compare
I just hit this issue trying to update xcode from Thanks for the multiple attempts to fix it in different repositories @keith 🙏 How are you currently dealing with this problem? I am not sure how to work around it considering that:
Some options on the top of my mind:
|
Instead of maintaining a fork, you can apply a patch with bazel: https://brentley.dev/patching-bazel-external-dependencies/ |
Yep that's what I would recommend in general, and what we're doing at Lyft. I felt a bit weird about merging this at the time because I wasn't sure if it would have any unexpected side-effects. Realistically we could probably merge it now, but I was hoping that my actual fixes upstream would land soon enough that we wouldn't need too. Unfortunately it looks like they won't be fixed until Swift 5.6, which I assume won't come to Xcode until the spring |
Got it, thank you 🙌 |
4951b9d
to
8a4fde7
Compare
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/262 (must be Lyft employee to view) |
8a4fde7
to
0f341bf
Compare
0f341bf
to
c09ef2f
Compare
The linked SR is closed. Is it still a valid bug that should be reopened? |
needs more investigation, i think there's a new one |
This works around an issue in Swift 5.5 / Xcode 13.0 beta 5 where absolute paths to the sources being compiled are _always_ used and embedded in the case a vfs overlay is used. This tricks the compiler by using a vfs overlay for the source files as well. https://bugs.swift.org/browse/SR-15123
c09ef2f
to
aecc3f4
Compare
as of Xcode 14 we have confirmed this is fixed, and don't see any new reason to use this at the moment. I believe it was fixed earlier, with Swift 5.6, but I didn't test before Swift 5.7. Please file an issue if you find any new case that needs this! |
This works around an issue in Swift 5.5 / Xcode 13.0 beta 5 where
absolute paths to the sources being compiled are always used and
embedded in the case a vfs overlay is used. This tricks the compiler by
using a vfs overlay for the source files as well.
https://bugs.swift.org/browse/SR-15123