fix some build errors with latest rules_go #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jmhodges
force-pushed
the
upgrade_rules_go_for_pr
branch
from
baf891d
to
b3b64a6
Compare
joshbruning
approved these changes
Jun 29, 2017
Recent rules_go versions do not have a `url` parameter on `go_repository`, so rules_webtesting, unfortunately, has to be changed. There is also a new requirement that if a `urls` parameter is specified, than a `tag` or `commit` parameter may not be. So, we fix up the gorilla/mux and selenium deps. This patch also upgrades the rules_go external in this WORKSPACE to its current HEAD. This does not address the noci tag problem discussed in bazelbuild#147. Updates bazelbuild#147
jmhodges
force-pushed
the
upgrade_rules_go_for_pr
branch
from
b3b64a6
to
e912423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix build errors with latest rules_go
Recent rules_go versions do not have a
urlparameter ongo_repository, sorules_webtesting, unfortunately, has to be changed.
There is also a new requirement that if a
urlsparameter is specified, than atagorcommitparameter may not be. So, we fix up the gorilla/mux andselenium deps.
This patch also upgrades the rules_go external in this WORKSPACE to its current
HEAD.
This does not address the noci tag problem discussed in #147.
Updates #147