Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolchainInfo Schema #11

Merged
merged 4 commits into from
Oct 25, 2018
Merged

ToolchainInfo Schema #11

merged 4 commits into from
Oct 25, 2018

Conversation

brandjon
Copy link
Member

@brandjon brandjon commented Oct 3, 2018

This is a proposal to make ToolchainInfo resemble Target objects, by having its constructor take a sequence of provider instances, and retrieving provider instances by keying on the provider type.

I do not intend to implement this in the near future, but I suspect the design may be non-controversial.

@brandjon brandjon mentioned this pull request Oct 3, 2018
@brandjon
Copy link
Member Author

brandjon commented Oct 8, 2018

Any blockers to merging as a draft? (Sections / formatting / missing content)

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandjon brandjon merged commit 61836b1 into master Oct 25, 2018
@brandjon brandjon deleted the tcinfo-schema branch October 25, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants