Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options to b:undo_ftplugin #15

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

dkearns
Copy link
Contributor

@dkearns dkearns commented Sep 19, 2021

The bzl ftplugin inherits this variable from the sourced python ftplugin but doesn't restore the options it exclusively sets.

@google-cla
Copy link

google-cla bot commented Sep 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 19, 2021
@dkearns
Copy link
Contributor Author

dkearns commented Sep 19, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 19, 2021
@@ -53,13 +53,16 @@ let &l:tabstop = s:save_tabstop

setlocal formatoptions-=t

let b:undo_ftplugin .= " | setlocal fo<"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't b:undo_ftplugin not necessarily defined yet, in which case this would fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's defined in the sourced Python ftplugin sourced at line 43.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right! Could you put a comment above this line to note it's initially defined in ftplugin/python.vim?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dbarnett
Copy link
Contributor

Looks good, thanks! Merging.

@dbarnett dbarnett merged commit 6b41860 into bazelbuild:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants