Quickpick targets for registered Bazel commands #28
Conversation
|
Please resolve the lint errors shown by Travis; see the instructions I added recently for the recommended development setup with TSLint and Prettier to help automate this. |
| // workspace | ||
| if (vscode.window.activeTextEditor === undefined) { | ||
| vscode.window.showErrorMessage( | ||
| "Unable to determine Bazel workspace. Open a file in the Bazel workspace", |
There was a problem hiding this comment.
Using the active editor to determine the default workspace is reasonable, but if the user doesn't have an editor open, we still have enough information to present the user with a choice if they have one or more folders added to their workspace. So we could present them with a choice of those, and then query that.
I have some thoughts on how to consolidate decisions like this into a workspace cache and state machine that we can use across multiple features, so you can leave this for now, but I wanted to mention it.
|
|
||
| /** | ||
| * Represents a Bazel target in a QuickPick items window. Implements the | ||
| * IBazelCommandAdapter interface so that it can be given directly to any of the |
There was a problem hiding this comment.
Nit: when writing symbols in JSDoc, use the notation {@code IBazelCommandAdapter}.
|
Your latest commit also fixes #17. |
This also fixes #23