fix: Default to Python syntax highlighting theme #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bazelbuild#396. Changes the `.starlark` name suffix to `.python.starlark`. By using both `python` and `starlark`, vscode is able to default to Python highlighting if a color theme defines colors specifically for `python`. For example, default color themes in vscode use `keyword.operator.logical.python` to highlight `and`/`or`/`not`/`in`.
nicolasstucki
requested review from
coeuvre,
jfirebaugh,
cameron-martin and
vogelsgesang
as code owners
vogelsgesang
approved these changes
May 20, 2024
|
I know almost nothing about textmate grammars, but it looks reasonable on the face of it. |
vogelsgesang
changed the title
|
Thanks again for the pull request, @nicolasstucki! Merged 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #396. Changes the
.starlarkname suffix to.python.starlark.By using both
pythonandstarlark, vscode is able to default to Python highlighting if a color theme defines colors specifically forpython. For example, default color themes in vscode usekeyword.operator.logical.pythonto highlightand/or/not/in.