Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build warnings #32

Open
bazz1tv opened this issue Jun 6, 2020 · 0 comments
Open

Cleanup build warnings #32

bazz1tv opened this issue Jun 6, 2020 · 0 comments

Comments

@bazz1tv
Copy link
Owner

bazz1tv commented Jun 6, 2020

There are lots of compiler warnings. LOTS. LOTS.

Simply pick a module that has some warnings and take it one source file at a time. Most warnings are a simple fix, while others may deserve more care.

I'm going to mark this issue as a "good first issue" for anyone interested in contributing to snestracker. I intend on GPL'ing the software, incase you were curious about the license

bazz1tv added a commit that referenced this issue Jul 25, 2020
Helps with #32, and fixes fatal runtime issues on Snow Leopard.
KungFuFurby added a commit to KungFuFurby/snestracker that referenced this issue May 20, 2021
Only a void function is allowed to have a return statement: otherwise, the warning can prove to be fatal post-compilation as the routine runs past the end of the code into some other undefined territory.

This commit should resolve every single instance of the warning "control may reach end of non-void function" (whether it always/sometimes does so or not).

This commit references bazz1tv#32.
KungFuFurby added a commit to KungFuFurby/snestracker that referenced this issue May 20, 2021
In the process of cherry picking and updating the previous commit, a few others
were discovered to have slipped by upon testing the compilation with the latest
public version, 0.2.2. This has been corrected.

This commit mentions bazz1tv#32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant