allow requirements to be specified on Mapper.resource

[sdague]

In OpenStack Nova we've used the prefix_path on Mapper.resource to
specify additional variables we want to capture (specifically
{project_id}). Project_id is a uuid. When trying to restrict
project_id to only valid uuid format a couple of issues were exposed.

• 1 '/{project_id:[a-f0-9]{32}}/...' builds an incorrect regex

  because of the nested {}

• 2 the preferred method that works on connect() to pass

  requirements doesn't work here (requirements are reset to only an
  id match)

That leaves us with having to build a custom project_id match with 32
[a-f0-9] strings appended for every resource added to get the support
we need without effectively vendoring our own version of Mapper.resource.

This small change to allow requirements to pass through would make it
possible to get this tighter validation with much smaller regexes.

[bbangert]

I'm fine allowing the requirements to make it through, but this PR is missing

• CHANGELOG.rst entry
• Test to verify it works as intended
• Docstring regarding the new option

If you could update it with those, I'd be happy to merge.

Thanks!

[sdague]

Thanks, updated with I think all the feedback you provided.

[bbangert]

Looks good, the only error is on an older Python where there is no assertIsNone apparently. Could just assertEqual to None for that.

[sdague]

Will update shortly with that fix.

    -Sean

Sean Dague
dague.net

On Jan 13, 2016, 10:41 AM, at 10:41 AM, Ben Bangert notifications@github.com wrote:

Looks good, the only error is on an older Python where there is no
assertIsNone apparently. Could just assertEqual to None for that.

---

Reply to this email directly or view it on GitHub:
#57 (comment)

[bbangert]

Thanks!