-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brick ontology and run rules based on meta data? #21
Comments
You could set it up such that each fault condition defines a set of "target" brick classes (outside_air_temperature_sensor) that are required for each analysis to run. |
Yes absolutely but I may need some help. I have an example ipynb notebook
that I am working on for an AHU. I'll give it a crack and check back with
you to see if this is what you envisioned on running fault rules against a
data model.
…On Mon, Aug 12, 2024, 4:50 PM Brian ***@***.***> wrote:
You could set it up such that each fault condition defines a set of
"target" brick classes (outside_air_temperature_sensor) that are required
for each analysis to run.
It would also be helpful to see a matrix of brick classes and fault
conditions to see where there is overlap between the fault conditions and
the required classes.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHC4BHOMWGR7AUCCKFMY7YLZREUZTAVCNFSM6AAAAABLKPG6OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUHE3DIMZTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@bsimmons-onboard can you check this out? examples/ahu_fault_one_brick.ipynb https://github.com/bbartling/open-fdd/blob/master/examples/ahu_fault_one_brick.ipynb Real curious on your thoughts I haven't worked with ontologies a whole lot so its a learning experience for me but if it looks cool i can overhaul the repo for it. Cell 11 the column mapping...
that seem legit? |
this is also the fault code running under the hood with a BRICK make over which would need to be done for all fault rules. https://github.com/bbartling/open-fdd/blob/master/open_fdd/air_handling_unit/faults/fault_condition_one.py |
Thanks for the example! Interesting, now I see where you're going with BRICK query. I was thinking that the query is abstracted away from the fault condition rules. Intuitively I'd expect to run the fault analysis on a df of time-series data where the column names are the BRICK classes (Supply_Air_Static_Pressure_Sensor). That can save some complexity on managing the translation, and if they are defined in the fault condition class as And I like the direction of adding the errors if columns are missing |
If anyone has any ideas to try please let me know. I would love to eventually be able to write FDD reports where fault rules run based on meta data alone Vs having to do this below and making sure all your data has the correct column names.... which is as bad as trying to use Microsoft Excel.
The text was updated successfully, but these errors were encountered: