Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move smartparens pair definition out of hooks #585

Merged
merged 1 commit into from
Jun 25, 2014

Conversation

toctan
Copy link
Contributor

@toctan toctan commented Jun 25, 2014

There are two reasons for doing this:

  • It's inefficient, we don't have to define the pairs every time we
    enter the mode.
  • It's extremely difficult to override the pair definition, even with
    eval-after-load and add-hook

There are two reasons for doing this:
- It's inefficient, we don't have to define the pairs every time we
  enter the mode.
- It's extremely difficult to override the pair definition, even with
  `eval-after-load` and `add-hook`
bbatsov added a commit that referenced this pull request Jun 25, 2014
Move smartparens pair definition out of hooks
@bbatsov bbatsov merged commit 2437b44 into bbatsov:master Jun 25, 2014
@bbatsov
Copy link
Owner

bbatsov commented Jun 25, 2014

👍

@toctan toctan deleted the smartparens branch June 25, 2014 13:21
celkins pushed a commit to celkins/prelude that referenced this pull request Jun 11, 2015
Move smartparens pair definition out of hooks
hbin pushed a commit to hbin/emacs.d that referenced this pull request Feb 22, 2017
Move smartparens pair definition out of hooks
hbin pushed a commit to hbin/emacs.d that referenced this pull request Feb 22, 2017
Move smartparens pair definition out of hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants