Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom theme cannot be auto installed #802

Closed
wants to merge 1 commit into from
Closed

Fix custom theme cannot be auto installed #802

wants to merge 1 commit into from

Conversation

goofansu
Copy link

According to README, I put (setq prelude-theme 'solarized-dark) in personal/preload/override.el. But it reports error as the package has not been installed.

I want to make the package auto installed while not modifying the Prelude code, so I suppose to move the (load-theme prelude-theme t) to init.el and after the personal configs. Then I can use (prelude-require-package 'solarized-dark) to auto install the theme package.

@CNBorn
Copy link
Contributor

CNBorn commented Jul 30, 2015

Second this one. This actually makes theme changing possible.

@CNBorn
Copy link
Contributor

CNBorn commented Aug 11, 2015

@goofansu do you mind to rebase with the upstream?

@toctan
Copy link
Contributor

toctan commented Aug 12, 2015

@goofansu Nope. That's not the way to do it. The personal directory is loaded after prelude but the personal/preload directory gets loaded before prelude. So you can put this line (prelude-require-package 'solarized-dark) anywhere in personal/preload, then it would work perfectly.

See https://github.com/bbatsov/prelude#preloading-personal-config

@CNBorn
Copy link
Contributor

CNBorn commented Aug 12, 2015

@toctan https://github.com/bbatsov/prelude/blob/master/init.el#L101 prelude-require-package are in prelude-package.el, which is loaded after preload scripts. There will be an error when you do prelude-require-package in preload script

@goofansu
Copy link
Author

@CNBorn Thanks 👍

@toctan
Copy link
Contributor

toctan commented Aug 12, 2015

@CNBorn @goofansu Oh my bad, but I still do not think it's a very good idea to move the theme loading code out of prelude-ui.el.

@goofansu
Copy link
Author

goofansu commented Aug 12, 2015 via email

@toctan
Copy link
Contributor

toctan commented Sep 3, 2015

@goofansu You can circumvent this by (require 'prelude-packages) before (prelude-require-package 'solarized-dark) in your preloaded configuration file.

@CNBorn
Copy link
Contributor

CNBorn commented Sep 9, 2015

@goofansu You can circumvent this by (require 'prelude-packages) before (prelude-require-package 'solarized-dark) in your preloaded configuration file.

Tested, that's seemingly a good way to do this.

@goofansu
Copy link
Author

goofansu commented Oct 6, 2015

@toctan Thanks, closed.

@goofansu goofansu closed this Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants