Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In emacs 28 "when" parameter are mandatory in function define-obsolete-variable-alias #1635

Closed
vpxyz opened this issue Jan 4, 2021 · 1 comment

Comments

@vpxyz
Copy link

vpxyz commented Jan 4, 2021

In emacs 28 (master branch), the "when" parameter are mandatory in functions make-obsolete, define-obsolete-function-alias, make-obsolete-variable and define-obsolete-variable-alias.
The issue in caused by the line 4878:
(define-obsolete-variable-alias 'projectile-mode-line-lighter 'projectile-mode-line-prefix)

Expected behavior

projectile run as usual

Actual behavior

emacs are unable to load projectile:

  #f(compiled-function (obsolete-name current-name when &optional docstring) "Make OBSOLETE-NAME a variable alias for CURRENT-NAME and mark it obsolete.....)  
(define-obsolete-variable-alias 'projectile-mode-line-lighter 'projectile-mode-line-prefix)
  eval-buffer(#<buffer  *load*-693182> nil "/home/vincenzo/.emacs.d/elpa/projectile-20210104.7..." nil t)  ; Reading at buffer position 208182

Steps to reproduce the problem

Load projectile with emacs 28 (master branch)

Environment & Version information

Projectile version information

Projectile 20210104.700

Emacs version

GNU Emacs 28.0.50 (build 31, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
of 2021-01-04

Operating system

Fedora 33

@bbatsov bbatsov closed this as completed in c31bd41 Jan 4, 2021
@bbatsov
Copy link
Owner

bbatsov commented Jan 4, 2021

Thanks for reporting this!

hlissner added a commit to doomemacs/doomemacs that referenced this issue Jan 9, 2021
Fuco1/smartparens@7f5825d -> Fuco1/smartparens@63695c6
bbatsov/projectile@d1cfad0 -> bbatsov/projectile@c31bd41
domtronn/all-the-icons.el@6917b08 -> domtronn/all-the-icons.el@9aa16ae
iqbalansari/restart-emacs@e570749 -> iqbalansari/restart-emacs@1607da2
jscheid/dtrt-indent@a7ade6d -> jscheid/dtrt-indent@854b9a1
justbur/emacs-which-key@ca268fd -> justbur/emacs-which-key@428aedf
jwiegley/use-package@caa92f1 -> jwiegley/use-package@365c73d
radian-software/straight.el@3277e1c -> radian-software/straight.el@a32c97c

+ Closes #4513
+ Fixes (wrong-number-of-arguments (3 . 4) 2) error for users on Emacs
  HEAD (see bbatsov/projectile#1635).
+ package! :build semantics have changed due to upstream changes. What
  was :build is now :pre-build. What was :no-build is now :build nil.
+ Now we must be careful not to auto-disable the "use-package" psuedo
  theme. It is used as a place to store :custom assignments without them
  being saved to custom.el.
tummychow added a commit to tummychow/emacs that referenced this issue Aug 23, 2023
arch just got emacs28, but it currently doesn't have native compilation
enabled, which hits radian-software/straight.el#743
because i was using an ancient version of straight. then it also ran
into bbatsov/projectile#1635 and
emacs-evil/evil#1401 so i had to bump those too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants