Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom hashifying #135

Merged
merged 3 commits into from
Jul 8, 2013
Merged

Custom hashifying #135

merged 3 commits into from
Jul 8, 2013

Conversation

rejeep
Copy link
Contributor

@rejeep rejeep commented Jul 5, 2013

Hi,

I read about the decision to remove hashifying in #108. It has been bugging me for quite some time that it was removed from projectile. Without hashifying, projectile's find file functionality is almost useless to me.

This pull request contains two commits:

The second commit allows you to specify whatever completion function you want. Since I really don't want files relative to the root, but rather just the file name, I created this function. I'm not sure if you want this function as a part of projectile, if you do, tell me and I'll add it. Otherwise people that find it useful can simply add it to their Emacs config.

Note that I just created this hence has not been tested that well.

@bbatsov
Copy link
Owner

bbatsov commented Jul 8, 2013

I'm ok with the change. Please, update the documentation accordingly to reflect this change. You can also list your completion function there as an example of a custom completion function.

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

Do you mean that I should link to my gist from the doc and show an example of how to use it?

Do you have any other documentation than the README?

@bbatsov
Copy link
Owner

bbatsov commented Jul 8, 2013

Yep for the gist. Documentation == README.

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

@bbatsov Added some docs.

bbatsov added a commit that referenced this pull request Jul 8, 2013
@bbatsov bbatsov merged commit 0d4df86 into bbatsov:master Jul 8, 2013
@bbatsov
Copy link
Owner

bbatsov commented Jul 8, 2013

Looks good! Thanks!

P.S. It seems that your previous PR has broken the travis build:

$ make deps
make: *** No rule to make target `deps'.  Stop.

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

@bbatsov Looks like the branch wasn't rebased

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

Also, It looks like I missed this: https://github.com/bbatsov/projectile/blob/master/.travis.yml#L7 Should be:

- make elpa

@bbatsov
Copy link
Owner

bbatsov commented Jul 8, 2013

Will you prepare another PR?

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

For the whole thing? Then it would be my name in the merge message (if that's ok with you).

@bbatsov
Copy link
Owner

bbatsov commented Jul 8, 2013

Sure.

@rejeep
Copy link
Contributor Author

rejeep commented Jul 8, 2013

See #138

@pashky
Copy link

pashky commented Sep 11, 2013

@rejeep your function won't work with 'alien' indexing method enabled, as there's no cache in this case. This one just does matches against original choices array and will work in any case https://gist.github.com/pashky/6522273

@rejeep
Copy link
Contributor Author

rejeep commented Sep 12, 2013

@pashky Nice catch, thanks! I updated my Gist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants