-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom hashifying #135
Custom hashifying #135
Conversation
Otherwise the file will be cached twice.
I'm ok with the change. Please, update the documentation accordingly to reflect this change. You can also list your completion function there as an example of a custom completion function. |
Do you mean that I should link to my gist from the doc and show an example of how to use it? Do you have any other documentation than the README? |
Yep for the gist. Documentation == README. |
@bbatsov Added some docs. |
Looks good! Thanks! P.S. It seems that your previous PR has broken the travis build:
|
@bbatsov Looks like the branch wasn't rebased |
Also, It looks like I missed this: https://github.com/bbatsov/projectile/blob/master/.travis.yml#L7 Should be:
|
Will you prepare another PR? |
For the whole thing? Then it would be my name in the merge message (if that's ok with you). |
Sure. |
See #138 |
@rejeep your function won't work with 'alien' indexing method enabled, as there's no cache in this case. This one just does matches against original choices array and will work in any case https://gist.github.com/pashky/6522273 |
@pashky Nice catch, thanks! I updated my Gist! |
Hi,
I read about the decision to remove hashifying in #108. It has been bugging me for quite some time that it was removed from projectile. Without hashifying, projectile's find file functionality is almost useless to me.
This pull request contains two commits:
The second commit allows you to specify whatever completion function you want. Since I really don't want files relative to the root, but rather just the file name, I created this function. I'm not sure if you want this function as a part of projectile, if you do, tell me and I'll add it. Otherwise people that find it useful can simply add it to their Emacs config.
Note that I just created this hence has not been tested that well.