Fix tramp alien index find file with relative paths. #1477
Conversation
|
@bbatsov It seams something wrong with test concerning projectile-project-root and its cache? But I cant understand why. |
projectile.el
Outdated
| ;; getting directory name without ":" for tramp connections | ||
| (c_directory (car (last (split-string directory ":"))))) | ||
|
|
||
| (mapcar (lambda (f) |
There was a problem hiding this comment.
I haven't looked at the test failure, but I can tell you that walking over all the files and applying an extra transformation is going to have a terrible performance impact on any non-trivial project.
There was a problem hiding this comment.
Thanks!) Ok, that's was kind of hack to make file list more compact without long prefix /home/user/<proj_root>/ for hg repos. It's seams better place for that was projectile-hg-command (change hg locate to hg files). By chance hg files also returns project file list in more compact way without long prefix.
replace deprecated hg locate to hg files. Replace tramp remote names with local names when create project list files in alien mode.
|
@bbatsov Last commit likely fixed some test failures for Travis emacs 26 and snapshot, but strangely not so for emacs 25. |
|
This feature is somewhat buggy and still need to be refined. |
Alien indexing method returned absolute file paths which in turn failed
projectile-find-filein Tramp session for me. Got that working with fix in the wayprojectile-dir-files-aliencreate list of files with relative paths instead of absolute paths. And I believe its solves the wayprojectile-find-file-in-dirworks with alien indexing with tramp.Closes: #1275