fix helm-projectile-ack #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe use the |
kain88-de
referenced
this pull request
Jun 16, 2015
So far only the globally ignored files/directories have been used while the grep command uses also the ignored files/directories defined in `.projectile`
|
The fix looks good. Just update the commit message to match the project's conventions (mention the fixed issue, capitalise the commit title, etc). Look in the history and you'll understand what I mean. |
|
👍 |
I forgot to actually call the projectile-ignored-directory/files functions in my previous fix (PR bbatsov#767) of bbatsov#766.
|
I updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to wrap projectile-ignored-files/directories in parenthesis to actually call the functions.
see #767