TrivialAccessors check problem

[lenntt]

I have some subclass that overrides a method:

def some_method
  @variable_with_a_different_name
end

Rubocop thinks this is a TrivialAccessor offence, but I tend to disagree. What do you think? I dont think there is an easy way to refactor this into an attr_reader?

[bbatsov]

This behaviour is intentional. Despite the different name this is still an attr_reader. You can always use alias_method to access the attribute via a different name.

At some point we might introduce some configuration regarding exact name matches.

@yujinakayama @jonas054 Would you share your thoughts on the subject?

[lenntt]

Thanks for the fast and clear explanation. Its not what I can directly derrive from the ruby-style-guide.

What if I want to keep my @variable_with_a_different_name hidden?.
There are of course ways to implement it, but I don't think it would make my code better readable.

[bbatsov]

Even now you can simply instruct RuboCop to skip the TrivialAccessors check for that particular method.

[lenntt]

Thanks, that could be useful (though I strongly dislike having rubocop-specific code in my source code).

[yujinakayama]

Though I think TrivialAccessors is not perfect, but at least in this case, I don't think the offence is a problem.

With the provided information, I wonder why you don't use @some_method (though this is unpractical name, probably something like @some_attr) internally and just declare attr_reader :some_method.

[badal]

One use case may be duck-typing. You may have to provide a definition
def duck_typed_method
@another_name
end