Build fails

[jonas054]

Many specs from cli_spec.rb are failing currently. See Travis-CI. This started with the introduction of the Coveralls code coverage gem.

All the failing specs fail for the same reason. A colored text is uncolored, which doesn't work, and then compared to an expected string without ANSI escape sequences. The comparison fails.

First I thought that the reason was that Coveralls and RuboCop both use ANSI coloring, but that they use different gems to achieve this. I tried changing RuboCop to use colorize (used by Coveralls) instead of term-ansicolor. That didn't help one bit.

Since it's the calls to String#uncolored that don't work, we could remove them and colorize all the expected strings instead. This fails to address the root cause, but it works. Should I implement this solution, or can anybody else find a better, more thorough solution?

[bbatsov]

colorize patches String as well and that's causing the breakage. The proper way to fix this would be to remove the term-ansicolor mixin from String and introduce some helper methods instead (that might even understand a --no-color flag). We might also report an issue to coveralls - colorize is pretty buggy so they might consider replacing it... I wasn't able to make it uncolourize text at all. I noticed somebody reported a bug regarding coveralls + colorized a month ago, but it hasn't been addressed. I'll take care of this tomorrow if I can.

[jonas054]

I took care of it based on your description. I hope you think it's OK. I just removed the "monkey patching" and didn't add helper methods.

[bbatsov]

Looks good. We can always improve this in the future.