Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple rubocop:disable comments per line #4282

Closed

Conversation

vergenzt
Copy link
Contributor

Supporting this would make implementing #4127 much easier because the code wouldn't ever have to add cops to an existing rubocop:disable comment--it could always simply append # rubocop:disable <cop>.

What do you think?


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@vergenzt vergenzt force-pushed the support-multiple-disable-comments branch from 6a311b2 to 6c60d9d Compare April 15, 2017 20:27
@rrosenblum
Copy link
Contributor

I think that I prefer # rubocop:disable Cop1, Cop2 over # rubocop:disable Cop1 # rubocop:disable Cop2.

@vergenzt
Copy link
Contributor Author

That works. 👍 I'll work out the logic to modify existing statements.

@vergenzt vergenzt closed this Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants