Treat files containing invalid byte sequences as non-matches #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mclark
force-pushed
the
fix-regexp-path-matching
branch
2 times, most recently
from
102eaef
to
8cd52a6
Compare
bbatsov
reviewed
Apr 25, 2017
spec/rubocop/path_util_spec.rb
Outdated
| @@ -78,7 +78,7 @@ | |||
|
|
|||
| it 'matches regexps' do | |||
| expect(described_class.match_path?(/^d.*e$/, 'dir/file')).to be_truthy | |||
| expect(described_class.match_path?(/^d.*e$/, 'dir/filez')).to be_falsey | |||
| expect(described_class.match_path?(/^d.*e$/, "dir/file\xBF")).to be_falsey | |||
There was a problem hiding this comment.
I'd probably have this as a separate example for clarity's sake.
|
Your change should be accompanied by a changelog entry. |
mclark
force-pushed
the
fix-regexp-path-matching
branch
2 times, most recently
from
9cb1248
to
d6b2638
Compare
If a file path contains a non-UTF8 character and we are matching against a regular expression, an ArgumentError is thrown, failing the entire operation. Since it is not a valid byte sequence for the encoding, we can assume it is not a match and return false instead.
mclark
force-pushed
the
fix-regexp-path-matching
branch
from
d6b2638
to
6469ea0
Compare
|
@bbatsov thanks for the 👀 ! I've addressed your feedback, feel free to take another look when you get a chance. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file path contains a non-UTF8 character and we are matching
against a regular expression, an ArgumentError is thrown,
failing the entire operation. Since it is not even a valid byte
sequence for the encoding, we can assume it is not a match and
return false instead.
With this change, if there are paths on the file system that are not
valid UTF-8 we will just treat them as not matching the
regular expression and continue processing instead of failing
with an exception.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).and description in grammatically correct, complete sentences.