Display 'Running parallel inspection' only with --debug #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the problem with printing the message unconditionally. The fix is fine as far as I'm concerned. It's a change to released functionality that's visible for the user, so a change log entry is needed. |
In parallel mode, `--format` option may not be work well. For example ```bash $ rubocop --parallel --format json | jq . parse error: Invalid numeric literal at line 1, column 8 ``` Because RuboCop prints a message if `--parallel` is received. This change fixes the problem by removing the message if `--debug` is not received.
pocke
force-pushed
the
parallel-with-format
branch
from
e98acbc
to
20a5506
Compare
|
I added a changelog entry. Thanks! |
bbatsov
reviewed
May 29, 2017
| @@ -49,7 +49,7 @@ def abort | |||
| # Warms up the RuboCop cache by forking a suitable number of rubocop | |||
| # instances that each inspects its alotted group of files. | |||
| def warm_cache(target_files) | |||
| puts 'Running parallel inspection' | |||
| puts 'Running parallel inspection' if @options[:debug] | |||
There was a problem hiding this comment.
We should probably create some debug_puts method or something at some point.
This this is still going to be broken with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parallel mode,
--formatoption may not be work well.For example
Because RuboCop prints a message if
--parallelis received.This change fixes the problem by removing the message if
--debugis not received.WDYT? cc: @jonas054
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).