Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cop generator rubocop-compliant #4943

Merged
merged 5 commits into from
Nov 1, 2017
Merged

Make cop generator rubocop-compliant #4943

merged 5 commits into from
Nov 1, 2017

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Oct 26, 2017

I noticed while working on #4937 that the cop generator generates files that are not passing the internal investigation. This PR adds a test that checks it.
Actual fix will come in a 2nd commit to make sure tests were failing and make then green


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov bbatsov merged commit 65a120c into rubocop:master Nov 1, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants