Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Rails/AssertNot cop #5805

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Conversation

composerinteralia
Copy link
Contributor

@composerinteralia composerinteralia commented Apr 21, 2018

Following the pattern of #5801, this cop imports a custom cop
from rails/rails#32605.

This cop checks for the use of assert !:

# bad
assert !foo

# good
assert_not foo

As in #5801, since assert_not is a method defined in ActiveSupport,
this cop belongs in the Rails namespace.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@composerinteralia composerinteralia force-pushed the assert-not branch 3 times, most recently from 60c7ba3 to b412585 Compare April 21, 2018 14:05
Following the pattern of rubocop#5801, this cop imports a custom cop
from rails/rails#32605.

This cop checks for the use of `assert !`:

```
assert !foo

assert_not foo
```

As in rubocop#5801, since `assert_not` is a method defined in ActiveSupport,
this cop belongs in the Rails namespace.
@bbatsov bbatsov merged commit e07fd3f into rubocop:master Apr 23, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 23, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants