Autocorrect BracesAroundHashParameters cop. #612
Conversation
|
Coverage decreased (-0.09%) when pulling c7d77b847121c7f215b49f2ceb997b1a6dc2bc50 on dblock:autocorrect-braces-around-hash-parameters into 415e648 on bbatsov:master. |
|
Coverage decreased (-0.09%) when pulling c7d77b847121c7f215b49f2ceb997b1a6dc2bc50 on dblock:autocorrect-braces-around-hash-parameters into 415e648 on bbatsov:master. |
| @@ -75,43 +75,48 @@ | |||
|
|
|||
| describe 'registers an offence for' do | |||
| it 'one non-hash parameter followed by a hash parameter with braces' do | |||
| inspect_source(cop, ['where(1, { y: 2 })']) | |||
| corrected = autocorrect_source(cop, ['where(1, { y: 2 })']) | |||
There was a problem hiding this comment.
Normally we keep the auto-correct examples separated from the detection examples.
There was a problem hiding this comment.
I know, but I think it might be a bad idea. This duplicates the entire test for no added benefit, there's at least a dozen of those. Lmk if you still feel otherwise. Also note that autocorrect_source is inspect_source + autocorrect.
There was a problem hiding this comment.
We generally have only a few auto-correct examples, since it's pretty obvious that if the detection examples work the auto-correction examples will also work. It's a matter of good style for spec examples to test just one thing at a time.
There was a problem hiding this comment.
Btw, +10 on all this nitpicking. I am usually that guy doing the nitpicking and it's nice to find people who are even crazier than me about spaces and parenthesis.
|
Coverage decreased (-0.09%) when pulling c1835205053dbfb015ea6cc37b7b0778dbafa096 on dblock:autocorrect-braces-around-hash-parameters into e4c8a22 on bbatsov:master. |
|
Split autocorrect tests, this should be good to merge. |
…rameters Autocorrect BracesAroundHashParameters cop.
Pretty straightforward. I think the autocorrect could also get rid of the extra spacing, but I couldn't get that to work.