Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid :style unspecified box properties #448

Merged
merged 1 commit into from Dec 4, 2023

Conversation

aclonegeek
Copy link
Contributor

Fixes #447

unspecified is not a valid style for :box properties, but it wasn't rejected because of a bug in Emacs that would allow invalid attributes of :box so long as it was the last one in the list. This has been recently fixed in Emacs' master branch (see this commit).

@thomasf thomasf merged commit 922b595 into bbatsov:master Dec 4, 2023
@thomasf
Copy link
Collaborator

thomasf commented Dec 4, 2023

thanks

@widefox
Copy link

widefox commented Dec 4, 2023

Thank you

@aclonegeek aclonegeek deleted the fix-invalid-style branch December 4, 2023 12:26
@wdenton
Copy link

wdenton commented Dec 4, 2023

Thanks! For some reason just updating didn't work, I had to delete the solarized-theme ELPA directory and reinstall, but then all was well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid face box: :line-width, 4, :color, "grey90", :style, nil
4 participants