Allow data-class attribute to be copied when replacing background image #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen replacing background image
|
Well, the only altered attribute is the Do you rather mean that the |
|
Sorry, I was not clear: it is just consistency. I am replacing both placeholders and background images on the same page and I think that using the same convention would make sense. |
|
Yep you are right, it makes sense :-) |
thom4parisot
pushed a commit
that referenced
this pull request
Jan 9, 2015
Allow data-class attribute to be copied when replacing background image
|
Thank you @albertfdp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a div where the background image is replaced, the existing classes were not kept.