[Ready] Migrate functionality from Publisher #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revett
force-pushed
the
feat/publisher_migration
branch
from
bad0d54
to
98785cf
Compare
added 2 commits
October 8, 2014 15:54
revett
changed the title
|
@Integralist @darnould @stevenjack Just committed the last spec, so now ready for review. Note that some of the unit tests are missing (raised issue #6). 🏄 |
|
Will need to bump the version up from |
| 'components', | ||
| 'foo' | ||
| ) | ||
| subject { Alephant::Renderer } |
There was a problem hiding this comment.
I'm pretty sure that subject is automatically set to an instance of Alephant::Renderer implicitly as it's referenced in the describe above.
|
The CI job was failing due to hard-coding the Rspec options into each Rake task - as To fix this I used rake-rspec and rely upon users having a .rspec file in their home directory. |
revett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the rendering functionality of Alephant sits within the Publisher (moved in #5). Due to a new publisher gem being created to deal with messages that are received via a request, the functionality needs to be extracted back out into this gem. Note: this gem is not currently being used anywhere.
Solution
Move the current rendering functionality into this gem, ignoring what is currently in this repo. After this is done the Publisher will be refactored to use this gem.