Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses pipenv to manage deps #8

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Uses pipenv to manage deps #8

merged 3 commits into from
Nov 13, 2018

Conversation

moschopsuk
Copy link
Contributor

@moschopsuk moschopsuk commented Nov 8, 2018

Use pipenv to manage deps rather than using global pip hopefully not cause any issues such as #6

Basic guide:
brew install pipenv libffi
export PKG_CONFIG_PATH="/usr/local/opt/libffi/lib/pkgconfig"
pipenv install
pipenv run python3 brave.py

@moschopsuk moschopsuk added the enhancement New feature or request label Nov 8, 2018
Copy link
Contributor

@dantailby dantailby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@matthew1000
Copy link
Collaborator

The diff I just made was required for it to work for me

@moschopsuk moschopsuk merged commit 0bf3c52 into master Nov 13, 2018
@moschopsuk moschopsuk deleted the feat/pipenv branch November 13, 2018 10:10
@moschopsuk moschopsuk added this to the 1.2.0 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants