Skip to content

Commit

Permalink
feed v2: Add postTask to xsurface
Browse files Browse the repository at this point in the history
Bug: b/165288064, 1117571
Change-Id: Id7d98858484644044c5ac6da8714541a0eae0d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363388
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800218}
  • Loading branch information
Dan Harrington authored and Commit Bot committed Aug 20, 2020
1 parent 623e0d1 commit f297677
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
Expand Up @@ -23,6 +23,7 @@
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.base.task.PostTask;
import org.chromium.base.task.TaskTraits;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.AppHooks;
import org.chromium.chrome.browser.feed.shared.ScrollTracker;
Expand Down Expand Up @@ -250,6 +251,23 @@ public void logError(String tag, String format, Object... args) {
public void logWarning(String tag, String format, Object... args) {
Log.w(tag, format, args);
}

@Override
public void postTask(int taskType, Runnable task, long delayMs) {
TaskTraits traits;
switch (taskType) {
case ProcessScopeDependencyProvider.TASK_TYPE_UI_THREAD:
traits = UiThreadTaskTraits.DEFAULT;
break;
case ProcessScopeDependencyProvider.TASK_TYPE_BACKGROUND_MAY_BLOCK:
traits = TaskTraits.BEST_EFFORT_MAY_BLOCK;
break;
default:
assert false : "Invalid task type";
return;
}
PostTask.postDelayedTask(traits, task, delayMs);
}
}

/**
Expand Down
Expand Up @@ -46,4 +46,18 @@ default void logWarning(String tag, String messageTemplate, Object... args) {}
default ImageFetchClient getImageFetchClient() {
return null;
}

// Posts task to the UI thread.
int TASK_TYPE_UI_THREAD = 1;
// Posts to a background thread. The task may block.
int TASK_TYPE_BACKGROUND_MAY_BLOCK = 2;

/**
* Runs task on a Chrome executor, see PostTask.java.
*
* @param taskType Type of task to run. Determines which thread and what priority is used.
* @param task The task to run
* @param delayMs The delay before executing the task in milliseconds.
*/
default void postTask(int taskType, Runnable task, long delayMs) {}
}

0 comments on commit f297677

Please sign in to comment.