fix: client was not receiving data from server in local dev #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed by adding this.projectsUrl inside constructor of APIWrapper class
pietrop
added this to In progress
in BBC News Labs - (0) Digital Paper Edit - Sprint Board
pietrop
moved this from In progress
to Review in progress
in BBC News Labs - (0) Digital Paper Edit - Sprint Board
jamesdools
reviewed
Jun 25, 2019
BBC News Labs - (0) Digital Paper Edit - Sprint Board
automation
moved this from Review in progress
to Reviewer approved
Jun 25, 2019
jamesdools
approved these changes
Jun 25, 2019
BBC News Labs - (0) Digital Paper Edit - Sprint Board
automation
moved this from Reviewer approved
to Done
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
#33
Describe what the PR does
fixes #33 by adding
this.projectsUrlinside constructor of APIWrapper classState whether the PR is ready for review or whether it needs extra work
Ready for review
Additional context
NA