Feature: Add support for optional timeout. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasR
reviewed
Jan 10, 2018
| }); | ||
| }); | ||
|
|
||
| it('ignores cache timeout error and requests from the system of record.', () => { |
There was a problem hiding this comment.
What is meant by from the system of record?
There was a problem hiding this comment.
It's an official caching term for source system e.g our episodes API
|
cache.timeouts - good idea. Do you want that as part of this PR or can I add it later? |
|
Same PR please. |
|
cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
https://jira.dev.bbc.co.uk/browse/IPLAYER-31846
Implementation notes:
.gethas been implemented. Writes are out of scope for this PR.ignoreCacheErrorsso we can bypass cache if a lookup is taking too long