Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated keyCode property in KeyboardEvent #31

Closed
wielorzeczownik opened this issue Sep 8, 2023 · 1 comment · Fixed by #34
Closed

Deprecated keyCode property in KeyboardEvent #31

wielorzeczownik opened this issue Sep 8, 2023 · 1 comment · Fixed by #34
Labels
enhancement New feature or request

Comments

@wielorzeczownik
Copy link

Description:
Currently, the use of the keyCode property in the KeyboardEvent object is not recommended. I suggest you consider adding the ability to use both key and keyCode interchangeably.

Additional context
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
@wielorzeczownik wielorzeczownik added the enhancement New feature or request label Sep 8, 2023
@jordanholt jordanholt mentioned this issue Sep 22, 2023
Merged
5 tasks
@jordanholt
Copy link
Contributor

jordanholt commented Sep 22, 2023 •
edited
Loading

Thanks for flagging to us @wielorzeczownik, got a PR up to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow key as well as keyCode for directional key bbc/lrud-spatial
2 participants
@jordanholt @wielorzeczownik