Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow key as well as keyCode for directional key #34

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Allow key as well as keyCode for directional key #34

merged 1 commit into from
Sep 22, 2023
+20 −6

Conversation

jordanholt
Copy link
Contributor

Description

Rename and update the direction key parameter of getNextFocus to support both the (deprecated) keyCode value and the standard key value.

Motivation and Context

Closes #31.

How Has This Been Tested?

Verified in test harness when changing handler to pass key instead of keyCode.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jordanholt jordanholt marked this pull request as ready for review September 22, 2023 16:40
@jordanholt jordanholt requested a review from a team as a code owner September 22, 2023 16:40
@jordanholt jordanholt merged commit f3dad0d into master Sep 22, 2023
1 check passed
@jordanholt jordanholt deleted the add-key-support branch September 22, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murreey Murreey Murreey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated keyCode property in KeyboardEvent
2 participants
@jordanholt @Murreey