Don't use client bounding rect X/Y values #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing the use of
Element.getBoundingClientRect
's x and y values with left and top. They're always the same number.Motivation and Context
On some old browsers, the x and y properties don't exist. We've polyfilled to fix it in most cases, but this change means the library works everywhere out the box again, without relying on polyfills.
How Has This Been Tested?
No functionality change, all tests are still passing. Will verify it on some broken devices.
Checklist: