Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use client bounding rect X/Y values #32

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Murreey
Copy link
Contributor

@Murreey Murreey commented Sep 19, 2023

Description

Replacing the use of Element.getBoundingClientRect's x and y values with left and top. They're always the same number.

Motivation and Context

On some old browsers, the x and y properties don't exist. We've polyfilled to fix it in most cases, but this change means the library works everywhere out the box again, without relying on polyfills.

How Has This Been Tested?

No functionality change, all tests are still passing. Will verify it on some broken devices.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Murreey Murreey requested a review from a team as a code owner September 19, 2023 09:19
@Murreey Murreey merged commit a123ff8 into master Sep 19, 2023
1 check passed
@Murreey Murreey deleted the fix-buggy-client-bounding-rect branch September 19, 2023 09:34
@JohnPaulHarold
Copy link

thanks, was about to raise this issue. Saw this on YouView 2nd and 3rd gen Humax devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants