Fix data-focus updating when exit is blocked #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring how
data-focus
is applied again. Previous fix in #38 still wasn't quite right, as it changed the attributes before the blocked exit checks happen.elem
is actually a focusable, so it doesn't store IDs of containers or potentially any element that's been passed inMotivation and Context
Fixes a bug where if movement into a new container is blocked by
data-block-exit
, it still gets its data-focus modified to the candidate that it was going to try to move to. The focus should only update when it actually moves.How Has This Been Tested?
Existing data-focus tests still pass, added a new test for this specific behaviour. Checked that it fails on master, passes on this branch.
Checklist: