Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types #15

Merged
merged 6 commits into from
Jun 5, 2019
Merged

Types #15

merged 6 commits into from
Jun 5, 2019

Conversation

thomascgray
Copy link
Contributor

Adding some real types to LRUD

Changelog

  • created an interfaces file and using said interfaces
  • cleaned up logic around node.parents as its now redundant
    • tests have been updated to remove references to parents as well
  • updated tsconfig to include declarations, plus output destinations
  • updated build command to run npx tsc

@thomascgray thomascgray requested a review from a team June 5, 2019 12:36
Copy link
Contributor

@jordanholt jordanholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a way to avoid compiling with tsc and then again in the rollup process, but we can come back to that 👍

@thomascgray
Copy link
Contributor Author

Yep, agreed - as discussed, in the future, we should look at either;

  • making the rollup build process understand declarations
  • running rollup on the output of a tsc

@thomascgray thomascgray merged commit d90a8e5 into master Jun 5, 2019
@maxmilton
Copy link

maxmilton commented Jun 6, 2019

Typically if I want both a rollup build and .d.ts generated I'll run tsc --declaration --emitDeclarationOnly on top of the normal build.

@jordanholt jordanholt deleted the types branch September 24, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants