Update ProxyFix to work with Werkzeug 0.15 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Werkzeug 0.15 moved the location of the fixer middleware (see https://werkzeug.palletsprojects.com/en/0.15.x/changes/#version-0-15-0)
Makes it possible to set `fix_proxy` to a number, in which case this is the number of proxy headers to trust. Preserves previous "enabled"/"disabled" behaviour as well.
Update ProxyFix import location to match Werkzeug 0.15 Enable "fixing" more than one layer of proxy.
samdbmg
requested review from
andrewbonney,
simonrankine,
dannymeloy and
a team
This was referenced Mar 25, 2019
|
Closing in favour of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Werkzeug 0.15 makes some changes to ProxyFix to move where it is imported from and use a different signature - this makes the corresponding changes in nmos-common.
I'm not completely sure how this is going to interact with the Debian packages though, which I suspect are still on an older version of Werkzeug. I suppose we could pin it back instead?