Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Minimist vulnerability updates #3327

Merged
merged 3 commits into from Apr 6, 2020
Merged

Minimist vulnerability updates #3327

merged 3 commits into from Apr 6, 2020

Conversation

j-pendlebury
Copy link
Contributor

@j-pendlebury j-pendlebury commented Apr 2, 2020

Resolves #3268

Overall change: Run npm audit fix to fix vulnerability issues with minimist.

Code changes:

  • Update to package-lock via npm audit fix

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@j-pendlebury j-pendlebury self-assigned this Apr 2, 2020
@j-pendlebury j-pendlebury added dependencies Pull requests that update a dependency file ws-home Tasks for the WS Home Team ws-media The World Service media stream ws-articles Tasks for the WS Articles Team labels Apr 2, 2020
@j-pendlebury j-pendlebury added this to PR in Progress in Simorgh via automation Apr 2, 2020
@j-pendlebury j-pendlebury moved this from PR in Progress to Code review in Simorgh Apr 2, 2020
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Checked it out locally, and there are no vulnerabilities.

Simorgh automation moved this from Code review to Ready for Test Apr 3, 2020
@j-pendlebury j-pendlebury moved this from Ready for Test to Ready for merge (probably) in Simorgh Apr 3, 2020
@amywalkerdev amywalkerdev merged commit d0b421a into latest Apr 6, 2020
Simorgh automation moved this from Ready for merge (probably) to Done Apr 6, 2020
@amywalkerdev amywalkerdev deleted the security-fixes branch April 6, 2020 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update packages using minimist
4 participants