Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update react-helmet #3388

Merged
merged 6 commits into from Apr 17, 2020
Merged

Update react-helmet #3388

merged 6 commits into from Apr 17, 2020

Conversation

EinsteinNjoroge
Copy link
Contributor

Part of bbc/simorgh#3893

Overall change: Update react-helmet.

Code changes:

  • Update react-helmet.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@EinsteinNjoroge EinsteinNjoroge self-assigned this Apr 16, 2020
@EinsteinNjoroge EinsteinNjoroge added this to PR in Progress in Simorgh via automation Apr 16, 2020
@EinsteinNjoroge EinsteinNjoroge added ws-home Tasks for the WS Home Team ws-media The World Service media stream ws-articles Tasks for the WS Articles Team labels Apr 16, 2020
@EinsteinNjoroge EinsteinNjoroge moved this from PR in Progress to Code review in Simorgh Apr 16, 2020
@EinsteinNjoroge EinsteinNjoroge marked this pull request as ready for review April 16, 2020 14:33
amywalkerdev
amywalkerdev approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Simorgh automation moved this from Code review to Ready for Test Apr 16, 2020
FK78
FK78 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@FK78 FK78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bopchy
Bopchy reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this branch and tried running the tests locally after an npm ci:packages. There still seem to be warnings coming from packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx and
packages/containers/psammead-timestamp-container/src/index.test.jsx

@EinsteinNjoroge
Copy link
Contributor Author

EinsteinNjoroge commented Apr 16, 2020 •
edited

I pulled this branch and tried running the tests locally after an npm ci:packages. There still seem to be warnings coming from packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx and
packages/containers/psammead-timestamp-container/src/index.test.jsx

@Bopchy Nice catch, it's should fixed now

@Bopchy
Copy link
Contributor

Bopchy commented Apr 17, 2020

Checked it out locally, and all the relevant warnings are now gone. Thanks for the changes!

@EinsteinNjoroge
Copy link
Contributor Author

This PR does not require testing since it's a dependency update.

@EinsteinNjoroge EinsteinNjoroge moved this from Ready for Test to Ready for merge (probably) in Simorgh Apr 17, 2020
@EinsteinNjoroge EinsteinNjoroge merged commit 6c3b814 into latest Apr 17, 2020
Simorgh automation moved this from Ready for merge (probably) to Done Apr 17, 2020
@EinsteinNjoroge EinsteinNjoroge deleted the update-react-helmet branch April 17, 2020 08:18
This was referenced Apr 17, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bopchy Bopchy Bopchy approved these changes

@FK78 FK78 FK78 approved these changes

@amywalkerdev amywalkerdev amywalkerdev approved these changes

@DenisHdz DenisHdz DenisHdz approved these changes

Assignees

@EinsteinNjoroge EinsteinNjoroge

Labels
ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EinsteinNjoroge @Bopchy @FK78 @amywalkerdev @DenisHdz