Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept fraction with just a numerator #39

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

philipnbbc
Copy link
Contributor

Details

This PR supports reading fractions with an optional denominator (which defaults to 1). It does not change writing fracions to avoid breaking cases where the denominator is not optional in the JSON schema.

The TAMS for example has frame_rate specified with an optional denominator.

Pivotal Story

Story URL: Part of https://www.pivotaltracker.com/story/show/187542840

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

but write both numerator and denominator to avoid breaking cases
where the denominator is not optional in the JSON schema.

sem-ver: feature
@philipnbbc philipnbbc requested a review from a team as a code owner May 13, 2024 07:50
@philipnbbc philipnbbc merged commit 60317ea into main May 15, 2024
3 checks passed
@philipnbbc philipnbbc deleted the philipn-fraction-ator branch May 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants