Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #175

Merged
merged 43 commits into from
Aug 13, 2019
Merged

Develop #175

merged 43 commits into from
Aug 13, 2019

Commits on Mar 22, 2019

  1. added support for docx - needs better integration altho it works

    Pietro Passarelli - News Labs committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    7ec2609 View commit details
    Browse the repository at this point in the history
  2. adding timecodes and speakers to plain text export

    Pietro Passarelli - News Labs committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    0a408f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. develop: Fix 159 performance problem (#171)

    * moved header into a component
    
    with shouldComponentUopdate false to avoid unecessary re-renders - test
    
    * moved Header component into separate file
    
    +removed unused styling, commented out for now in case it's needed, eg in mobile view?
    
    * moved playback_rates const into separate file
    
    * optimised re-render of playback rate
    
    * optimise re-render for VideoPlayer
    
    * added some notes - draft
    
    on how to prevent uncessary re-renders in React
    
    * Added some comments
    
    * small note in docs
    
    about using console.log in render to measure performance
    
    * ammend to notes
    
    * Update 2019-05-16-prevent-unnecessary-re-renders-in-react.md
    
    * notes update
    
    * notes fix
    
    * trying out why-did-you-update
    
    * updated MediaPlayer and subcomponents
    
    * made ToolTip 'how does this work' into it's own component
    
    * updated Demo app to reduce unecessary re-renders
    
    * added react-visibility-sensor
    
    * refactor settings
    
    * removed unecessary attributes from state of components + WrapperBlock performance tweak using react-visibility-sensor
    Pietro committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    58db590 View commit details
    Browse the repository at this point in the history
  2. develop: Update timestamps diff (#172)

    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    Pietro committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    59505b0 View commit details
    Browse the repository at this point in the history
  3. develop: Murezzda update timestamps diff (#173)

    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    
    * some changes to show sudgestions for PR
    
    * added some of changes sudgested in PR
    
    * Update package.json
    Pietro committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    a8ed136 View commit details
    Browse the repository at this point in the history
  4. develop: Murezzda update timestamps diff dpe groups words by speaker (#…

    …174)
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    
    * some changes to show sudgestions for PR
    
    * added some of changes sudgested in PR
    
    * adjusted DPE adapter
    
    so that it preserves paragraphs break within contiguos speakers
    
    * fixed one test
    
    * commented out auto align
    
    left aligning as a step before save btn and before export function, rather then as a step that happens everytime autosave is triggered, as that might be unecessary, and add performance overhead, I also noticed the cursor position jumped after realignement, thought something was been put in place to preserve/avoid that?
    Pietro committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b0ac0c0 View commit details
    Browse the repository at this point in the history
  5. updated package-lock

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    2e364d8 View commit details
    Browse the repository at this point in the history
  6. fixed vulneranilities

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    1d4e992 View commit details
    Browse the repository at this point in the history
  7. Getting ready to publish alpha

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ce31500 View commit details
    Browse the repository at this point in the history
  8. 1.0.4-alpha.0

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ac7658a View commit details
    Browse the repository at this point in the history
  9. 1.0.4@alpha

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    8602e1b View commit details
    Browse the repository at this point in the history
  10. fixed notes

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f5dfcd5 View commit details
    Browse the repository at this point in the history
  11. changing speaker and timecodes to be unselectable

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    9535e02 View commit details
    Browse the repository at this point in the history
  12. 1.0.4-alpha.1

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c09b748 View commit details
    Browse the repository at this point in the history
  13. 1.0.4-alpha.1

    unselectabel speakers and timecodes
    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f7f536d View commit details
    Browse the repository at this point in the history
  14. fix speaker and timecodes at paragraph level after realignement

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    fe8d03b View commit details
    Browse the repository at this point in the history
  15. 1.0.4-alpha.2

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    efe3ada View commit details
    Browse the repository at this point in the history
  16. merged conflicts with develop branch

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d9020b9 View commit details
    Browse the repository at this point in the history
  17. Merge branch 'docx-spike-2' into develop

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6f49b05 View commit details
    Browse the repository at this point in the history
  18. fixed docx integration

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    4319001 View commit details
    Browse the repository at this point in the history
  19. Subtitles export (#168)

    * added option to export srt files
    
    and layout to export other type of captions with auto segmentation of lines
    
    * added support for other subtitles formats
    Pietro committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ffb68a8 View commit details
    Browse the repository at this point in the history
  20. fixed npm audit

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    36aaf0a View commit details
    Browse the repository at this point in the history
  21. implemented export in UI

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    a176e54 View commit details
    Browse the repository at this point in the history
  22. fixed test

    added sample files for adding tests for subtitle composer module at later stage
    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    9d725b7 View commit details
    Browse the repository at this point in the history
  23. added optional analytics

    for export download options
    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c1e7ebc View commit details
    Browse the repository at this point in the history
  24. updated CSS

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    df10a38 View commit details
    Browse the repository at this point in the history
  25. 1.0.4-alpha.3

    Pietro Passarelli - News Labs committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    a8a89b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. fixed subtiles segmentation

    algo was picking the wrong words from the list
    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    91eaa93 View commit details
    Browse the repository at this point in the history
  2. moved PR template in github folder

    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    3b7ae7f View commit details
    Browse the repository at this point in the history
  3. cleaned up code for subtitles parsing

    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    66174ae View commit details
    Browse the repository at this point in the history
  4. 1.0.4-alpha.4

    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    08742c1 View commit details
    Browse the repository at this point in the history
  5. fixed alignement algo

    after interpolation words time boundares  where overlapping
    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    ee3f4ec View commit details
    Browse the repository at this point in the history
  6. fixed interpolation

    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    7710c17 View commit details
    Browse the repository at this point in the history
  7. fixed filename of word doc export

    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    40cdb5f View commit details
    Browse the repository at this point in the history
  8. fixed TimeBox

    and playback rate not working
    Pietro Passarelli - News Labs committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    df111a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. 1.0.4-alpha.5

    Pietro Passarelli - News Labs committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    0855005 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. removed scroll sync (#181)

    fix #180
    Pietro committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    af019bd View commit details
    Browse the repository at this point in the history
  2. refactor

    changes from James review #160
    Pietro Passarelli - News Labs committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    3588b26 View commit details
    Browse the repository at this point in the history
  3. Develop branch - should component update refactor (#182)

    * Refactor should component updatre for transcript editor
    
    * Refactor should component updatre for PlayerControls
    
    * Refactor should component updatre for TimeBox
    
    * Refactor should component update for ProgressBar
    
    * Refactor should component update for TimedTextEditor
    
    * Refactor should component update for Header
    Pietro committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    fe495f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. fix from PR review

    Fixed from James comments from #144 (review)
    Pietro Passarelli - News Labs committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    058a271 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' of github.com:bbc/react-transcript-editor into…

    … develop
    Pietro Passarelli - News Labs committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    71e9dee View commit details
    Browse the repository at this point in the history
  3. Update package.json

    Pietro committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    e132bb9 View commit details
    Browse the repository at this point in the history
  4. Update package.json

    Pietro committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    14151ea View commit details
    Browse the repository at this point in the history