Performance no entities spike #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from BBC repo
Updating from BBC
Updating from BBC master
added speaker batch change
…omRaw function calls
update from master
added Facebook's Zuck Senate hearing 5 hours example to the demo app to stress test edge cases
added try catch block around local storage saving to avoid app crashing if it runs out of memory during save in demo app
removed auto sync for performance on longer files, also added sync btn to restore timestamps
added as option to pass in speaker and timecodes labels as attributes to transcript editor with defaults
… but also save state to reflect in the editor
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
…act-transcript-editor into performance-no-entities-spike
renamed getWordsBeforeBlock to getWordsBeforeParagraphBlock
added requestIdleCallback before calling updateTimeStamps
replaced with word count see in code comments for more of an explanation
added 5 commits
March 17, 2020 14:11
refactored alignement to use native draftJS methods instead converting to and from raw, to improve performance + re introducing scroll sync at paragraph level
they where showing up as NAN, eg if a transcript time started at zero, edge case
…t recognising dpe folder
|
👋 update pietrop#13 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Fixes this #150 and addresses comment #150 (comment) and duplicate of PR pietrop#13 on my fork.
Describe what the PR does
Fixes #150, see description in duplicate PR pietrop#13 on my fork.
State whether the PR is ready for review or whether it needs extra work
Ready to review
Additional context
Might be easier to first review this by looking at pietrop#13 and then adjust the repo diffs between the two forks etc..