Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Section Label to use correct colour in secondary column #6587

Closed
2 tasks done
simonsinclair opened this issue May 20, 2020 · 0 comments · Fixed by #6875
Closed
2 tasks done

Update Section Label to use correct colour in secondary column #6587

simonsinclair opened this issue May 20, 2020 · 0 comments · Fixed by #6875
Assignees
Labels
ux To be reviewed by UX before merging ws-articles Tasks for the WS Articles Team

Comments

@simonsinclair
Copy link
Contributor

simonsinclair commented May 20, 2020

Is your feature request related to a problem? Please describe.

Titles in the secondary column are created using psammead-section-label, which uses a link a colour (EBON). When used in the secondary column, these are not links and therefore should use #3F3F42 (SHADOW).

Describe the solution you'd like

  • Update psammead-section-label component to use colour EBON if the section label is a link and SHADOW if it's not.
  • Ensure this change reflects correctly in the secondary column.

Note: This may require raising a Psammead issue. Whoever picks this up can create this if it's needed.

Describe alternatives you've considered

n/a

Testing notes

[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.
  • This feature is expected to have a UX review.

Additional context

n/a

@simonsinclair simonsinclair added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team ux To be reviewed by UX before merging labels May 20, 2020
@HarveyPeachey HarveyPeachey removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jun 5, 2020
@FK78 FK78 self-assigned this Jun 5, 2020
@lizcameron lizcameron added this to the [WSS] STY Batch 3 milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux To be reviewed by UX before merging ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants