-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node-fetch
#11266
Draft
amoore108
wants to merge
116
commits into
latest
Choose a base branch
from
revert-11261-revert-11122-remove-nodefetch
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove node-fetch
#11266
+317
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d122f4.
amoore108
changed the title
[DNM] Revert "Revert "Remove
[DNM] Remove Feb 9, 2024
node-fetch
""node-fetch
andrewscfc
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, hope this works for Opera ⭕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11261 and reinstates the original PR: #11122
Description from original PR:
Overall changes
Removes
node-fetch
andisomorphic-fetch
in favour of using Node 18+ built-in fetch mechanism, provided byundici
. Removes the need to do #9611undici
has been added as a dependency as we need itsAgent
constructor to use our custom certs to authenticate requests.This aligns the Express and Next.js app to use the same fetch mechanism across both apps, and removes the need to keep
node-fetch
updated through its transition to ESM.Code changes
node-fetch
andisomorphic-fetch
and the instances these libraries were importedgetAgent
function across the Express and Next.js appsAgent
andgetAgent
in testsfetchDataFromBFF
Testing
yarn
to install the new dependenciesyarn dev
renderer_env=live
flag to ensure it fetches Live data with the certs