WSTEAM1-945: Update e2e #11529
Merged
WSTEAM1-945: Update e2e #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…STEAM1-945-E2E-TESTS
alex-magana
reviewed
Apr 17, 2024
alex-magana
reviewed
Apr 17, 2024
alex-magana
reviewed
Apr 18, 2024
| describe(`testsThatFollowSmokeTestConfig to run for ${service} ${variant} ${pageType} `, () => { | ||
| it('should render a description for the page', () => { | ||
| cy.getPageData({ service, pageType: 'cpsAsset', variant }).then( | ||
| cy.getPageData({ service, pageType: pageTypeForFetch, variant }).then( |
There was a problem hiding this comment.
This is for fetching on Test/ Live enviornments.
|
|
||
| it('should render an iframe with a valid URL', () => { | ||
| if (!`${Cypress.env('currentPath')}`.includes('/russian/av/')) { | ||
| cy.getPageData({ service, pageType: 'cpsAsset', variant }).then( | ||
| cy.getPageData({ service, pageType: pageTypeForFetch, variant }).then( |
There was a problem hiding this comment.
This is for fetching on Test/ Live enviornments.
|
|
||
| it('should render an iframe with a valid URL', () => { | ||
| if (!`${Cypress.env('currentPath')}`.includes('/russian/av/')) { | ||
| cy.getPageData({ service, pageType: 'cpsAsset', variant }).then( | ||
| cy.getPageData({ service, pageType: pageTypeForFetch, variant }).then( |
There was a problem hiding this comment.
This is for fetching on Test/ Live enviornments.
amoore108
added a commit
that referenced
this pull request
Apr 24, 2024
* changes description targeting for block model format * adds article pageType * set iscaf to true for hausa pidgin and thai Co-authored-by: Shayne Marc Enzo Ahchoon <shayneahchoon@users.noreply.github.com> * check if optimo * fix optimo check * check pagetype ionstead of isoptimo * remove pagetype check * WSTEAM1-942: Update lint * Add Thai PGL asset * Enable fetching of cps PGL fixtures from article page handler * Add integration tests targetting CAF via thai * updates test to cater for caf only services * adds else clause * WSTEAM1-967: CAF - Update MAP Integration test and snapshots * Add Hausa CAF integration tests * Apply CPS id check from e2es PR * WSTEAM1-945: Update e2e (#11529) * WSTEAM1-945: Update e2e * WSTEAM1-945: Update settings * WSTEAM1-945: Update fixtures * WSTEAM1-945: Alter route * WSTEAM1-945: Fix HTML lang tests. * WSTEAM1-945: Update fixture * WSTEAM1-945: Fix PGL tests * WSTEAM1-945: Add tests * WSTEAM1-945: Update tests * WSTEAM1-945: Update tests * WSTEAM1-945: Update tests * WSTEAM1-945: Enable e2e tests on CAF STY pages. Update and add fixture data * WSTEAM1-945: Refactor cpsId check * WSTEAM1-945: refctor to assign to variable * WSTEAM1-945: Refactor * WSTEAM1-945: Update MAP fixture data to include ATI campaigns * WSTEAM1-945: Set Cypress getPageData pageType to article if isCaf * WSTEAM1-945: Lint and simplify post merge * WSTEAM1-945: Update snapshots * WSTEAM1-945: Update snapshots --------- Co-authored-by: Isabella Mitchell <i.mitchell.0707@gmail.com> Co-authored-by: Isabella Mitchell <98817636+Isabella-Mitchell@users.noreply.github.com> * Update snaphots to reflect SEO and ATI changes * Remove redundant isCaf flag * Use CafEnabledServices const across app * WSTEAM1-967: Import cafEnabledServices from lib * Add CPS id check for STY tests * Add CAF STY fixture asset * Remove apple itunes banner test * Update snapshot * Update snapshot to include SEO and ATI values * Update CAF STY snapshots to include lang code --------- Co-authored-by: Harvey Peachey <harvey.peachey@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <shayneahchoon@users.noreply.github.com> Co-authored-by: Aaron Moore <aaron.moore@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <shayne.ahchoon@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <32307964+shayneahchoon@users.noreply.github.com> Co-authored-by: alex-magana <alex.magana@andela.com> Co-authored-by: Isabella Mitchell <i.mitchell.0707@gmail.com> Co-authored-by: Isabella Mitchell <98817636+Isabella-Mitchell@users.noreply.github.com>
MeriemMechri
pushed a commit
that referenced
this pull request
May 12, 2024
* changes description targeting for block model format * adds article pageType * set iscaf to true for hausa pidgin and thai Co-authored-by: Shayne Marc Enzo Ahchoon <shayneahchoon@users.noreply.github.com> * check if optimo * fix optimo check * check pagetype ionstead of isoptimo * remove pagetype check * WSTEAM1-942: Update lint * Add Thai PGL asset * Enable fetching of cps PGL fixtures from article page handler * Add integration tests targetting CAF via thai * updates test to cater for caf only services * adds else clause * WSTEAM1-967: CAF - Update MAP Integration test and snapshots * Add Hausa CAF integration tests * Apply CPS id check from e2es PR * WSTEAM1-945: Update e2e (#11529) * WSTEAM1-945: Update e2e * WSTEAM1-945: Update settings * WSTEAM1-945: Update fixtures * WSTEAM1-945: Alter route * WSTEAM1-945: Fix HTML lang tests. * WSTEAM1-945: Update fixture * WSTEAM1-945: Fix PGL tests * WSTEAM1-945: Add tests * WSTEAM1-945: Update tests * WSTEAM1-945: Update tests * WSTEAM1-945: Update tests * WSTEAM1-945: Enable e2e tests on CAF STY pages. Update and add fixture data * WSTEAM1-945: Refactor cpsId check * WSTEAM1-945: refctor to assign to variable * WSTEAM1-945: Refactor * WSTEAM1-945: Update MAP fixture data to include ATI campaigns * WSTEAM1-945: Set Cypress getPageData pageType to article if isCaf * WSTEAM1-945: Lint and simplify post merge * WSTEAM1-945: Update snapshots * WSTEAM1-945: Update snapshots --------- Co-authored-by: Isabella Mitchell <i.mitchell.0707@gmail.com> Co-authored-by: Isabella Mitchell <98817636+Isabella-Mitchell@users.noreply.github.com> * Update snaphots to reflect SEO and ATI changes * Remove redundant isCaf flag * Use CafEnabledServices const across app * WSTEAM1-967: Import cafEnabledServices from lib * Add CPS id check for STY tests * Add CAF STY fixture asset * Remove apple itunes banner test * Update snapshot * Update snapshot to include SEO and ATI values * Update CAF STY snapshots to include lang code --------- Co-authored-by: Harvey Peachey <harvey.peachey@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <shayneahchoon@users.noreply.github.com> Co-authored-by: Aaron Moore <aaron.moore@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <shayne.ahchoon@bbc.co.uk> Co-authored-by: Shayne Marc Enzo Ahchoon <32307964+shayneahchoon@users.noreply.github.com> Co-authored-by: alex-magana <alex.magana@andela.com> Co-authored-by: Isabella Mitchell <i.mitchell.0707@gmail.com> Co-authored-by: Isabella Mitchell <98817636+Isabella-Mitchell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-945
Overall changes
Updates fixture data and settings for Cypress tests for Pidgin, Hausa and Thai services.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines