Fix for E2Es failing on webp test #11700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
eagerterrier
reviewed
Jun 5, 2024
| @@ -15,7 +15,7 @@ describe('getIchefURL', () => { | |||
|
|
|||
| describe('builds WebP ichef img url based on originCode, locator and resolution passed', () => { | |||
| const BASE_IMAGE_URL = 'https://ichef.bbci.co.uk'; | |||
|
|
|||
| // https://ichef.bbci.co.uk/ace/ws/400/cpsdevpb/2F4D/test/_63490121_110329105535_soweto_304x171_b_nocredit.gif.webp | |||
| // you leave the Cypress command queue and are using plain JS. Using .wrap converts | ||
| // the JQuery element into a Cypress wrapped element so we can execute Cypress commands on it | ||
|
|
||
| // Images are lazy loaded so we need to scroll to them, check they have loaded before getting currentSrc |
There was a problem hiding this comment.
Lovely use of commenting in this file. Love it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sport page has no image on. The tests now check for the presence of at least one img in the document before they run.
There were .gif images in the frosted promos for one test asset. '.gif' was not included in the isWebSupported array of accepted url regexes. I added it in the regex.
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines