-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1017: Initiate journey across Uploader states #11729
Conversation
…ge title with useEffect
ws-nextjs-app/pages/[service]/send/[id]/GenericMessage/index.tsx
Outdated
Show resolved
Hide resolved
ws-nextjs-app/pages/[service]/send/[id]/GenericMessage/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Just as a small tidy up, could this bit be removed:
simorgh/ws-nextjs-app/pages/[service]/send/[id]/FormScreen/index.tsx
Lines 73 to 79 in 2cfaad1
{submissionError && ( | |
<div css={styles.submissionError}> | |
{`Error: ${submissionError.status} - ${submissionError.code} - ${submissionError.message}`} | |
<br /> | |
{`Recoverable: ${submissionError.isRecoverable}`} | |
</div> | |
)} |
Don't think we'll need this, at least for now as it was more for debugging.
"Prefix page title with 'Uploading' on screen change. Remove on Success screen. (We already do this on the Error screen)." Do we add something on the success screen so the title is different to the start page? @Isabella-Mitchell |
I've updated this to use the |
Resolves JIRA WSTEAM1-1017 - Configure functionality for the journey across states (Form, uploading & Success)
Overall changes
Supporting the users journey across the various states of the uploader form. Default > Uploading > Success/ Error. Default > Validation Errors > Uploading > Success/ Error.
Code changes
Note I have added some basic unit tests to the Form. I'm looking at adding unit tests to the Form Context Provider though I don't think this should hold up the progress of this ticket.
Testing
(Note the form submission will error - check Slack for instructions on how to get form to submit successfully)
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines