-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically serve files in /data #37
Conversation
483567d
to
16d3fe1
Compare
3738e69
to
2a4acc1
Compare
cypress/integration/data_spec.js
Outdated
}); | ||
|
||
describe('Response Body', () => { | ||
it('should be an object', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
}); | ||
}); | ||
|
||
it('should contain a blocks object', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
}); | ||
|
||
describe('Response Body', () => { | ||
testScenarioRequest('should be an object', '01', ({ body }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
expect(body).to.be.an('object'); | ||
}); | ||
|
||
testScenarioRequest('should contain a blocks object', '01', ({ body }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
}); | ||
|
||
describe('Response Body', () => { | ||
testScenarioRequest('should be an object', ({ body }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
expect(body).to.be.an('object'); | ||
}); | ||
|
||
testScenarioRequest('should contain a blocks object', ({ body }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit 42813c2 and detected 0 issues on this pull request. View more on Code Climate. |
JIRA: https://jira.dev.bbc.co.uk/browse/NEWSART-546
Statically serves all files in the
/data
directory over/data
.JIRA ticket added
Pull request URL added to JIRA ticket
Up-to-date with latest -
git pull --rebase origin latest
Runs locally -
npm run dev
& http://localhost:7080/Tests added for new features
Tests pass -
npm test
E2E tests pass -
npm run test:e2e
(requires server running see README for details)Test engineer approval