Statically serve files in /data #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtart
force-pushed
the
NEWSART-546-serve-articles-data
branch
from
483567d
to
16d3fe1
Compare
jtart
force-pushed
the
NEWSART-546-serve-articles-data
branch
from
3738e69
to
2a4acc1
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
cypress/integration/data_spec.js
Outdated
| }); | ||
|
|
||
| describe('Response Body', () => { | ||
| it('should be an object', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should contain a blocks object', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
added 2 commits
June 6, 2018 10:58
cypress/integration/data_spec.js
Outdated
| }); | ||
|
|
||
| describe('Response Body', () => { | ||
| testScenarioRequest('should be an object', '01', ({ body }) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
| expect(body).to.be.an('object'); | ||
| }); | ||
|
|
||
| testScenarioRequest('should contain a blocks object', '01', ({ body }) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
| }); | ||
|
|
||
| describe('Response Body', () => { | ||
| testScenarioRequest('should be an object', ({ body }) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
cypress/integration/data_spec.js
Outdated
| expect(body).to.be.an('object'); | ||
| }); | ||
|
|
||
| testScenarioRequest('should contain a blocks object', ({ body }) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 42813c2 and detected 0 issues on this pull request. View more on Code Climate. |
jamesbrumpton
approved these changes
Jun 6, 2018
Closed
jamesbhobbs
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.dev.bbc.co.uk/browse/NEWSART-546
Statically serves all files in the
/datadirectory over/data.JIRA ticket added
Pull request URL added to JIRA ticket
Up-to-date with latest -
git pull --rebase origin latestRuns locally -
npm run dev& http://localhost:7080/Tests added for new features
Tests pass -
npm testE2E tests pass -
npm run test:e2e(requires server running see README for details)Test engineer approval