-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use webpack alias #3707
Use webpack alias #3707
Conversation
Are all aliases relative to the project root directory? |
Yes ^ @mykeels The jest alias is also relative to the root because of the |
Missing alias usage in |
Co-Authored-By: Drew McMillan <drew.mcmillan@bbc.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked tests, eslint, storybook. npm run dev
and npm run build
LGTM, great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #2567
Overall change:
This continues the work from this PR: #3542
Uses webpack directory aliasing previously set up in #3318
Cypress is not using the Aliases because it can not properly compile the aliases without webpack config
Code changes: