Frosted promos + isite #9732
Merged
Frosted promos + isite #9732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+4
to
+10
| export default loadable( | ||
| () => | ||
| import( | ||
| /* webpackChunkName: "frosted_promo" */ | ||
| '.' | ||
| ), | ||
| { fallback: <span data-testid="frosted-promo-loader" /> }, |
There was a problem hiding this comment.
This looks cool. So the browser doesn't load the component chunk outlined until it comes into view?
There was a problem hiding this comment.
Ah I'm not sure Loadable cares about scroll position - but it does exclude the code from the bundle if the component is not actually invoked at runtime though.
eg, without loadable, this component and it's subtree (which is quite big because of the colour picker) would need included in the bundle, even if the component was toggled off on isite
pvaliani
approved these changes
Dec 9, 2021
HarveyPeachey
approved these changes
Dec 9, 2021
ryanmccombe
commented
Dec 9, 2021
ryanmccombe
commented
Dec 9, 2021
ryanmccombe
commented
Dec 9, 2021
ryanmccombe
commented
Dec 9, 2021
ryanmccombe
commented
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [No Issue]
Overall change:
Allows promos to be controlled by toggles.
Code changes:
cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)