Issue #269 - fix the input to ChangeVisibilityTimeout to not include …

…the elapsed seconds
bbc · Aug 13, 2021 · 6a23fab · 6a23fab
1 parent 3cafbb7
commit 6a23fab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sqs-consumer",
-  "version": "5.5.0",
+  "version": "5.5.1",
   "description": "Build SQS-based Node applications without the boilerplate",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/consumer.ts b/src/consumer.ts
@@ -203,8 +203,8 @@ export class Consumer extends EventEmitter {
     let heartbeat;
     try {
       if (this.heartbeatInterval) {
-        heartbeat = this.startHeartbeat(async (elapsedSeconds) => {
-          return this.changeVisabilityTimeout(message, elapsedSeconds + this.visibilityTimeout);
+        heartbeat = this.startHeartbeat(async () => {
+          return this.changeVisabilityTimeout(message, this.visibilityTimeout);
         });
       }
       await this.executeHandler(message);
@@ -338,8 +338,8 @@ export class Consumer extends EventEmitter {
     let heartbeat;
     try {
       if (this.heartbeatInterval) {
-        heartbeat = this.startHeartbeat(async (elapsedSeconds) => {
-          return this.changeVisabilityTimeoutBatch(messages, elapsedSeconds + this.visibilityTimeout);
+        heartbeat = this.startHeartbeat(async () => {
+          return this.changeVisabilityTimeoutBatch(messages, this.visibilityTimeout);
         });
       }
       await this.executeBatchHandler(messages);
@@ -405,11 +405,9 @@ export class Consumer extends EventEmitter {
     }
   }
 
-  private startHeartbeat(heartbeatFn: (elapsedSeconds: number) => void): NodeJS.Timeout {
-    const startTime = Date.now();
+  private startHeartbeat(heartbeatFn: () => void): NodeJS.Timeout {
     return setInterval(() => {
-      const elapsedSeconds = Math.ceil((Date.now() - startTime) / 1000);
-      heartbeatFn(elapsedSeconds);
+      heartbeatFn();
     }, this.heartbeatInterval * 1000);
   }
 }